-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CosmosDBOptions
to allow configuration of the CosmosDB service client via CosmosClientOptions
#2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
force-pushed
the
liliankasem/cosmos/client-options
branch
from
May 23, 2024 00:05
821fe19
to
505712a
Compare
jviau
reviewed
May 30, 2024
liliankasem
changed the title
Expose CosmosClientOptions
Implement Jun 5, 2024
CosmosDBOptions
to allow configuration of the CosmosDB service client via CosmosClientOptions
jviau
reviewed
Jun 5, 2024
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBOptions.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Jun 5, 2024
extensions/Worker.Extensions.CosmosDB/src/Worker.Extensions.CosmosDB.csproj
Outdated
Show resolved
Hide resolved
jviau
reviewed
Jun 6, 2024
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptions.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Jun 6, 2024
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptions.cs
Outdated
Show resolved
Hide resolved
jviau
requested changes
Jun 11, 2024
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptions.cs
Outdated
Show resolved
Hide resolved
...ons/Worker.Extensions.CosmosDB/src/Extensions/FunctionsWorkerApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jviau
requested changes
Jun 12, 2024
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBExtensionOptions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptions.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Jun 12, 2024
jviau
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2450
Pull request checklist
release_notes.md
Additional information
Implement CosmosDBExtensionOptions for the cosmos extension that will expose
CosmosClientOptions
and allow users to configure the CosmosClient.